| changeset | 45aed809f9f7 |
|---|---|
| branch | default |
| bookmark | |
| tag | tip |
| user | PiotrZalewa |
| description | mozreview: implement moved chunk upstream fix (bug 1251455) r=smacleod Moved blocks are badly recognized. Sometimes, if a similar shorter block of code is found interdiff mistakenly choses it. Moved chunks are recognized, but are overwritten by the latest similar blocks. The fix is to remember the moved chunks and skip further recognition for already processed blocks. Another issue solved by this code is to differentiate left and right side of the move blocks. If there was a move from line number `A` to `X` and from line number `Y` line to `A`, left and right `A` lines where the same for the "jump" action. This could lead to link wrong blocks. This fix is implemented in the upstream. It needs to be removed before upgrading reviewboard. MozReview-Commit-ID: 6pPc1oeOJh1 |
| files | reviewboard/reviewboard/diffviewer/chunk_generator.py reviewboard/reviewboard/diffviewer/opcode_generator.py reviewboard/reviewboard/diffviewer/templatetags/difftags.py |
[default] mozreview: implement moved chunk upstream fix (bug 1251455) r=smacleod
↧
↧
Latest Images
Trending Articles
More Pages to Explore .....